[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/9] macio: fix possible memory leak
From: |
arei.gonglei |
Subject: |
[Qemu-devel] [PATCH 4/9] macio: fix possible memory leak |
Date: |
Fri, 27 Feb 2015 15:50:14 +0800 |
From: Gonglei <address@hidden>
If ret = macio_initfn_ide() is less than 0, the timer_memory
will leak the memory it points to.
Signed-off-by: Gonglei <address@hidden>
---
hw/misc/macio/macio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/misc/macio/macio.c b/hw/misc/macio/macio.c
index e0f1e88..bf96844 100644
--- a/hw/misc/macio/macio.c
+++ b/hw/misc/macio/macio.c
@@ -273,7 +273,7 @@ static int macio_newworld_initfn(PCIDevice *d)
MacIOState *s = MACIO(d);
NewWorldMacIOState *ns = NEWWORLD_MACIO(d);
SysBusDevice *sysbus_dev;
- MemoryRegion *timer_memory = g_new(MemoryRegion, 1);
+ MemoryRegion *timer_memory = NULL;
int i;
int cur_irq = 0;
int ret = macio_common_initfn(d);
@@ -301,6 +301,7 @@ static int macio_newworld_initfn(PCIDevice *d)
}
/* Timer */
+ timer_memory = g_new(MemoryRegion, 1);
memory_region_init_io(timer_memory, OBJECT(s), &timer_ops, NULL, "timer",
0x1000);
memory_region_add_subregion(&s->bar, 0x15000, timer_memory);
--
1.7.12.4
- [Qemu-devel] [PATCH 0/9] Coverity defects fixes, arei.gonglei, 2015/02/27
- [Qemu-devel] [PATCH 5/9] e500: fix memory leak, arei.gonglei, 2015/02/27
- [Qemu-devel] [PATCH 6/9] 9pfs: fix memory leak, arei.gonglei, 2015/02/27
- [Qemu-devel] [PATCH 8/9] sysbus: fix memory leak, arei.gonglei, 2015/02/27
- [Qemu-devel] [PATCH 1/9] nbd: fix resource leak, arei.gonglei, 2015/02/27
- [Qemu-devel] [PATCH 4/9] macio: fix possible memory leak,
arei.gonglei <=
- [Qemu-devel] [PATCH 9/9] microblaze: fix memory leak, arei.gonglei, 2015/02/27
- [Qemu-devel] [PATCH 7/9] milkymist.c: fix memory leak, arei.gonglei, 2015/02/27
- [Qemu-devel] [PATCH 3/9] sparc/leon3.c: fix memory leak, arei.gonglei, 2015/02/27
- [Qemu-devel] [PATCH 2/9] arm: fix memory leak, arei.gonglei, 2015/02/27
Re: [Qemu-devel] [PATCH 0/9] Coverity defects fixes, Michael Tokarev, 2015/02/28