[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RfC PATCH 06/15] virtio-gpu/2d: add virtio gpu core co

From: Max Reitz
Subject: Re: [Qemu-devel] [RfC PATCH 06/15] virtio-gpu/2d: add virtio gpu core code
Date: Fri, 27 Feb 2015 09:33:22 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 2015-02-27 at 09:31, Gerd Hoffmann wrote:
+    if (t2d.offset || t2d.r.x || t2d.r.y ||
+        t2d.r.width != pixman_image_get_width(res->image)) {
Will this work with stride != t2d.r.width * bpp?
Those cases should take the if branch above and loop over all lines to
handle it correctly.
Exactly, but it looks like to me that it doesn't (at least not always).
Ah, you mean we should better check something like

   t2d.r.width * bpp != pixman_image_get_stride() ?

That should check exactly the same thing as we never create resources
with extra padding where width * bpp != stride.

Ah, you're right, I missed that. Very well then.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]