[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v4 11/13] qapi: add md5 checksum of last dir
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RFC v4 11/13] qapi: add md5 checksum of last dirty bitmap level to query-block |
Date: |
Fri, 27 Feb 2015 11:32:47 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 02/27/2015 10:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Reviewed-by: John Snow <address@hidden>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> block.c | 1 +
> include/qemu/hbitmap.h | 8 ++++++++
> qapi/block-core.json | 4 +++-
> util/hbitmap.c | 8 ++++++++
> 4 files changed, 20 insertions(+), 1 deletion(-)
>
> +++ b/qapi/block-core.json
> @@ -336,11 +336,13 @@
> #
> # @frozen: whether the dirty bitmap is frozen (Since 2.3)
> #
> +# @md5: md5 checksum of the last bitmap level (since 2.3)
> +#
> # Since: 1.3
> ##
> { 'type': 'BlockDirtyInfo',
> 'data': {'*name': 'str', 'count': 'int', 'granularity': 'uint32',
> - 'disabled': 'bool', 'frozen': 'bool'} }
> + 'disabled': 'bool', 'frozen': 'bool', 'md5': 'str'} }
How long does it take to compute the md5 sum? Is enabling this
information unconditionally going to significantly slow down the call,
when the information is useful primarily only for debugging?
That said, it looks okay code-wise, so as long as I am not uncovering a
design flaw:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH RFC v4 00/13] Dirty bitmaps migration, Vladimir Sementsov-Ogievskiy, 2015/02/27
- [Qemu-devel] [PATCH RFC v4 09/13] iotests: add add_incoming_migration to VM class, Vladimir Sementsov-Ogievskiy, 2015/02/27
- [Qemu-devel] [PATCH RFC v4 03/13] block: tiny refactoring: minimize hbitmap_(set/reset) usage, Vladimir Sementsov-Ogievskiy, 2015/02/27
- [Qemu-devel] [PATCH RFC v4 05/13] block: add bdrv_next_dirty_bitmap(), Vladimir Sementsov-Ogievskiy, 2015/02/27
- [Qemu-devel] [PATCH RFC v4 06/13] qapi: add dirty-bitmaps migration capability, Vladimir Sementsov-Ogievskiy, 2015/02/27
- [Qemu-devel] [PATCH RFC v4 11/13] qapi: add md5 checksum of last dirty bitmap level to query-block, Vladimir Sementsov-Ogievskiy, 2015/02/27
- Re: [Qemu-devel] [PATCH RFC v4 11/13] qapi: add md5 checksum of last dirty bitmap level to query-block,
Eric Blake <=
- [Qemu-devel] [PATCH RFC v4 02/13] block: BdrvDirtyBitmap serialization interface, Vladimir Sementsov-Ogievskiy, 2015/02/27
- [Qemu-devel] [PATCH RFC v4 12/13] iotests: add dirty bitmap migration test, Vladimir Sementsov-Ogievskiy, 2015/02/27
- [Qemu-devel] [PATCH RFC v4 08/13] iotests: maintain several vms in test, Vladimir Sementsov-Ogievskiy, 2015/02/27
- [Qemu-devel] [PATCH RFC v4 13/13] migration/qemu-file: make functions qemu_(get/put)_string public, Vladimir Sementsov-Ogievskiy, 2015/02/27
- [Qemu-devel] [PATCH RFC v4 04/13] block: add meta bitmaps, Vladimir Sementsov-Ogievskiy, 2015/02/27
- [Qemu-devel] [PATCH RFC v4 01/13] hbitmap: serialization, Vladimir Sementsov-Ogievskiy, 2015/02/27
- [Qemu-devel] [PATCH RFC v4 10/13] iotests: add event_wait to VM class, Vladimir Sementsov-Ogievskiy, 2015/02/27
- [Qemu-devel] [PATCH RFC v4 07/13] migration: add migration/block-dirty-bitmap.c, Vladimir Sementsov-Ogievskiy, 2015/02/27
- Re: [Qemu-devel] [PATCH RFC v4 00/13] Dirty bitmaps migration, John Snow, 2015/02/27