[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Makefile.objs: add dummy rule for .dsl files
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] Makefile.objs: add dummy rule for .dsl files |
Date: |
Fri, 27 Feb 2015 19:41:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 26/02/2015 17:33, Michael S. Tsirkin wrote:
> .hex files are created from .dsl files, so
> cpp adds the dependency %.hex: %.dsl automatically,
> but fails to add a dummy rule so if .dsl
> file is missing, make will fail.
>
> This happened to us in the past when we
> removed some dsl files.
>
> Create an extra .d file with a dummy dependency.
>
> Cc: Peter Maydell <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/i386/Makefile.objs | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
> index 45b90a8..7a47914 100644
> --- a/hw/i386/Makefile.objs
> +++ b/hw/i386/Makefile.objs
> @@ -19,6 +19,7 @@ iasl-option=$(shell if test -z "`$(1) $(2) 2>&1 >
> /dev/null`" \
> ifdef IASL
> #IASL Present. Generate hex files from .dsl
> hw/i386/%.hex: $(SRC_PATH)/hw/i386/%.dsl
> $(SRC_PATH)/scripts/acpi_extract_preprocess.py
> $(SRC_PATH)/scripts/acpi_extract.py
> + $(call quiet-command, echo "$<:" > "$@"-extra.d, " DEP $@")
> $(call quiet-command, $(CPP) -x c -P $(QEMU_DGFLAGS) $(QEMU_INCLUDES)
> $< -o $*.dsl.i.orig, " CPP $(TARGET_DIR)$*.dsl.i.orig")
> $(call quiet-command, $(PYTHON)
> $(SRC_PATH)/scripts/acpi_extract_preprocess.py $*.dsl.i.orig > $*.dsl.i, "
> ACPI_PREPROCESS $(TARGET_DIR)$*.dsl.i")
> $(call quiet-command, $(IASL) $(call iasl-option,$(IASL),-Pn,) -vs -l
> -tc -p $* $*.dsl.i $(if $(V), , > /dev/null) 2>&1 ," IASL
> $(TARGET_DIR)$*.dsl.i")
>
Applied, thanks.
Paolo