[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type |
|
Date: |
Mon, 02 Mar 2015 08:56:15 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 02/27/2015 07:54 PM, zhanghailiang wrote:
> On 2015/2/28 0:48, Eric Blake wrote:
>> On 02/26/2015 11:19 PM, zhanghailiang wrote:
>>> The original 'status' is an open-coded 'str' type, convert it to use an
>>> enum type.
>>> +# @MigState:
>>
>> Do we have to abbreviate? I guess leaving it like this makes the rest
>> of the existing code base have less churn (since it matches the spelling
>> of the enum that was previous interanl only), but it might look nicer as
>
> Yes, this is the reason ..., agreed, i don't like the abbreviate,
> But there is already a 'MigrationState' type defined:
>
>
> So, what about MigrationStatus ? ;)
That would be fine with me.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature