[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type
From: |
Michael Mueller |
Subject: |
Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none |
Date: |
Tue, 3 Mar 2015 11:23:35 +0100 |
On Mon, 2 Mar 2015 16:17:33 -0300
Eduardo Habkost <address@hidden> wrote:
> > + if (probe_mode) {
> > + /* Use these accelerators in probe mode, tcg should be last */
> > + p = probe_mode_accels;
>
> I don't fully understand the purpose of this patch yet (I will discuss
> it in a reply to the cover letter). But if you really want -machine none
> to trigger different behavior, why you didn't add a probe_mode field
> to MachineClass, so you can set it in the mahine_none class code?
I initially had this machine attribute but, when I remember correctly, but
wasn't able to
communicate it down into the target code. But anyhow, the "mode" is eventually
obsolete in light
of the temporarily constructed accelerators.. I will further comment on this as
reply to your
comment on the cover letter to keep it in place.
Michael
- [Qemu-devel] [PATCH v3 00/16] s390x cpu model implementation, Michael Mueller, 2015/03/02
- [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none, Michael Mueller, 2015/03/02
- Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none, Andreas Färber, 2015/03/02
- Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none, Michael Mueller, 2015/03/02
- Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none, Andreas Färber, 2015/03/02
- Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none, Michael Mueller, 2015/03/03
- Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none, Eduardo Habkost, 2015/03/04
- Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none, Michael Mueller, 2015/03/05
- Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none, Eduardo Habkost, 2015/03/05
Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none, Eduardo Habkost, 2015/03/02
- Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none,
Michael Mueller <=
[Qemu-devel] [PATCH v3 03/16] Introduce stub routine cpu_desc_avail, Michael Mueller, 2015/03/02
[Qemu-devel] [PATCH v3 12/16] target-s390x: Prepare accelerator during cpu object realization, Michael Mueller, 2015/03/02
[Qemu-devel] [PATCH v3 13/16] target-s390x: New QMP command query-cpu-model, Michael Mueller, 2015/03/02
[Qemu-devel] [PATCH v3 07/16] target-s390x: Define cpu model specific facility lists, Michael Mueller, 2015/03/02
[Qemu-devel] [PATCH v3 11/16] target-s390x: Add cpu class initialization routines, Michael Mueller, 2015/03/02
[Qemu-devel] [PATCH v3 06/16] target-s390x: Introduce cpu models, Michael Mueller, 2015/03/02
[Qemu-devel] [PATCH v3 05/16] target-s390x: Generate facility defines per cpu model, Michael Mueller, 2015/03/02
[Qemu-devel] [PATCH v3 02/16] Introduce option --probe to switch into probe mode, Michael Mueller, 2015/03/02
[Qemu-devel] [PATCH v3 08/16] target-s390x: Add cpu model alias definition routines, Michael Mueller, 2015/03/02
[Qemu-devel] [PATCH v3 09/16] target-s390x: Update linux-headers/asm-s390/kvm.h, Michael Mueller, 2015/03/02