[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vl: take iothread lock very early
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH] vl: take iothread lock very early |
Date: |
Tue, 03 Mar 2015 12:13:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
Am 03.03.2015 um 11:36 schrieb Paolo Bonzini:
> If the iothread lock isn't taken by the main thread, the RCU callbacks
> might run concurrently with the main thread. QEMU's not ready for that.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
Tested-by: Christian Borntraeger <address@hidden>
> ---
> vl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 09693f5..d743727 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2763,6 +2763,9 @@ int main(int argc, char **argv, char **envp)
> FILE *vmstate_dump_file = NULL;
> Error *main_loop_err = NULL;
>
> + qemu_init_cpu_loop();
> + qemu_mutex_lock_iothread();
> +
> atexit(qemu_run_exit_notifiers);
> error_set_progname(argv[0]);
> qemu_init_exec_dir(argv[0]);
> @@ -4098,9 +4101,6 @@ int main(int argc, char **argv, char **envp)
>
> os_set_line_buffering();
>
> - qemu_init_cpu_loop();
> - qemu_mutex_lock_iothread();
> -
> #ifdef CONFIG_SPICE
> /* spice needs the timers to be initialized by this point */
> qemu_spice_init();
>
- [Qemu-devel] [PATCH] vl: take iothread lock very early, Paolo Bonzini, 2015/03/03
- Re: [Qemu-devel] [PATCH] vl: take iothread lock very early,
Christian Borntraeger <=
- Re: [Qemu-devel] [PATCH] vl: take iothread lock very early, Gonglei, 2015/03/03
- Re: [Qemu-devel] [PATCH] vl: take iothread lock very early, Peter Maydell, 2015/03/03
- Re: [Qemu-devel] [PATCH] vl: take iothread lock very early, Oliver Francke, 2015/03/03
- Re: [Qemu-devel] [PATCH] vl: take iothread lock very early, Paolo Bonzini, 2015/03/03
- Re: [Qemu-devel] [PATCH] vl: take iothread lock very early, Oliver Francke, 2015/03/03
- Re: [Qemu-devel] [PATCH] vl: take iothread lock very early, Paolo Bonzini, 2015/03/03
- Re: [Qemu-devel] [PATCH] vl: take iothread lock very early, Oliver Francke, 2015/03/03
- Re: [Qemu-devel] [PATCH] vl: take iothread lock very early, Christian Borntraeger, 2015/03/04
- Re: [Qemu-devel] [PATCH] vl: take iothread lock very early, Eric Blake, 2015/03/04
- Re: [Qemu-devel] [PATCH] vl: take iothread lock very early, Christian Borntraeger, 2015/03/05