[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 11/13] block: Add blk_remove_all_bs()
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v5 11/13] block: Add blk_remove_all_bs() |
Date: |
Tue, 3 Mar 2015 15:13:09 -0500 |
When bdrv_close_all() is called, instead of force-closing all root
BlockDriverStates, it is better to just drop the reference from all
BlockBackends and let them be closed automatically. This prevents BDS
from getting closed that are still referenced by other BDS, which may
result in loss of cached data.
This patch adds a function for doing that, but does not yet incorporate
it in bdrv_close_all().
Signed-off-by: Max Reitz <address@hidden>
---
block/block-backend.c | 13 +++++++++++++
include/sysemu/block-backend.h | 1 +
2 files changed, 14 insertions(+)
diff --git a/block/block-backend.c b/block/block-backend.c
index 76e6893..8eedc52 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -207,6 +207,19 @@ void blk_unref(BlockBackend *blk)
}
}
+void blk_remove_all_bs(void)
+{
+ BlockBackend *blk;
+
+ QTAILQ_FOREACH(blk, &blk_backends, link) {
+ AioContext *ctx = blk_get_aio_context(blk);
+
+ aio_context_acquire(ctx);
+ blk_remove_bs(blk);
+ aio_context_release(ctx);
+ }
+}
+
/*
* Return the BlockBackend after @blk.
* If @blk is null, return the first one.
diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h
index 3725e20..71f5292 100644
--- a/include/sysemu/block-backend.h
+++ b/include/sysemu/block-backend.h
@@ -67,6 +67,7 @@ BlockBackend *blk_new_open(const char *name, const char
*filename,
Error **errp);
void blk_ref(BlockBackend *blk);
void blk_unref(BlockBackend *blk);
+void blk_remove_all_bs(void);
const char *blk_name(BlockBackend *blk);
BlockBackend *blk_by_name(const char *name);
BlockBackend *blk_next(BlockBackend *blk);
--
2.1.0
- Re: [Qemu-devel] [PATCH v5 05/13] block: Move BDS close notifiers into BB, (continued)
- [Qemu-devel] [PATCH v5 12/13] block: Rewrite bdrv_close_all(), Max Reitz, 2015/03/03
- [Qemu-devel] [PATCH v5 09/13] block: Add list of all BlockDriverStates, Max Reitz, 2015/03/03
- [Qemu-devel] [PATCH v5 04/13] quorum: Fix close path, Max Reitz, 2015/03/03
- [Qemu-devel] [PATCH v5 11/13] block: Add blk_remove_all_bs(),
Max Reitz <=
- Re: [Qemu-devel] [PATCH v5 00/13] block: Rework bdrv_close_all(), Kevin Wolf, 2015/03/04