Re: [Qemu-devel] [PATCH v2 0/9] Block Throttle Group Support

[Stefan Hajnoczi]

On Fri, Feb 13, 2015 at 06:06:08PM +0200, Alberto Garcia wrote:
> after having agreed it with him, I'm taking over Benoît Canet's work
> to add support for throttle groups for block devices.

The locking rules are undocumented so it's hard to review the patches.

I think the intent is for throttling groups to be independent of
AioContext, so I/O can be processed in multiple threads at the same
time.  This requires synchronizing shared throttling state.

But the details of how the global throttle groups list is protected and
how individual ThrottleGroup and ThrottleState structs work is unclear.

Please resolve comments I've posted on individual patches and then
summarize the locking rules in a comment in throttle-groups.c.

Thanks,
Stefan

pgp3J4frZ6Y4E.pgp
Description: PGP signature