[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/5] target-i386: Move CPUX86State.cpuid_apic
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 2/5] target-i386: Move CPUX86State.cpuid_apic_id to X86CPU.apic_id |
|
Date: |
Tue, 3 Mar 2015 22:51:52 -0300 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Mar 02, 2015 at 06:51:44PM +0100, Andreas Färber wrote:
> Am 26.02.2015 um 22:42 schrieb Eduardo Habkost:
> > The field doesn't need to be inside CPUState, and it is not specific for
> > the CPUID instruction, so move and rename it.
> >
> > Reviewed-by: Paolo Bonzini <address@hidden>
> > Signed-off-by: Eduardo Habkost <address@hidden>
>
> Really great,
>
> Reviewed-by: Andreas Färber <address@hidden>
This has a funny side-effect visible to emulated code: the memcpy() at
cpu_copy() will not copy the APIC ID anymore and the APIC ID will be
different every time a new thread is created by *-user.
That's good news: it means we can already initialize apic_id to 0 on
*-user and existing behavior will be kept. But I recommend applying a
patch to do that (I will include one in v4 of this series) before this
one.
--
Eduardo