[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups |
Date: |
Sun, 8 Mar 2015 11:45:22 +0100 |
On Sun, Mar 08, 2015 at 09:15:41AM +0900, Peter Maydell wrote:
> On 8 March 2015 at 03:17, Michael S. Tsirkin <address@hidden> wrote:
> > OK Markus now confirmed this wasn't (necessarily) triggered
> > by these patches. So nothing should block this pull request now?
>
> Fails to build with clang:
>
> /home/petmay01/linaro/qemu-for-merges/hw/i386/acpi-build.c:471:20:
> error: unused function 'acpi_get_hex' [-Werror,-Wunused-function]
> static inline char acpi_get_hex(uint32_t val)
> ^
> 1 error generated.
>
> -- PMM
I can drop this one as a work around but I wonder why is clang warning
about unused static inlines.
We have a ton of these in each header and it doesn't warn,
in theory static inline should be same as macro: harmless
unless used.
Any idea?
--
MST
- [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups, Michael S. Tsirkin, 2015/03/04
- Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups, Markus Armbruster, 2015/03/06
- Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups, Peter Maydell, 2015/03/06
- Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups, Markus Armbruster, 2015/03/06
- Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups, Michael S. Tsirkin, 2015/03/07
- Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups, Michael S. Tsirkin, 2015/03/07
- Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups, Peter Maydell, 2015/03/07
- Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups, Peter Maydell, 2015/03/08
- Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups, Michael S. Tsirkin, 2015/03/08
Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups, Igor Mammedov, 2015/03/06
Re: [Qemu-devel] [PULL v5] pci, pc, virtio fixes and cleanups, Michael S. Tsirkin, 2015/03/07