[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 for-2.3 02/25] acpi: add aml_or() term
From: |
Shannon Zhao |
Subject: |
Re: [Qemu-devel] [PATCH v4 for-2.3 02/25] acpi: add aml_or() term |
Date: |
Mon, 9 Mar 2015 15:58:00 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 2015/3/8 19:16, Marcel Apfelbaum wrote:
> Add encoding for ACPI DefOr Opcode.
>
> Reviewed-by: Igor Mammedov <address@hidden>
> Signed-off-by: Marcel Apfelbaum <address@hidden>
> ---
> hw/acpi/aml-build.c | 10 ++++++++++
> include/hw/acpi/aml-build.h | 1 +
> 2 files changed, 11 insertions(+)
>
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index 0d14561..603c0c4 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -448,6 +448,16 @@ Aml *aml_and(Aml *arg1, Aml *arg2)
> return var;
> }
>
> +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefOr */
> +Aml *aml_or(Aml *arg1, Aml *arg2)
> +{
> + Aml *var = aml_opcode(0x7D /* OrOp */);
> + aml_append(var, arg1);
> + aml_append(var, arg2);
> + build_append_int(var->buf, 0x00); /* NullNameOp */
Hi,
I notice that MST has sent a patch which uses build_append_byte instead of
build_append_int.
Maybe we can fix this patch before apply.
Thanks,
Shannon
> + return var;
> +}
> +
- [Qemu-devel] [PATCH v4 for-2.3 00/25] hw/pc: implement multiple primary busses for pc machines, Marcel Apfelbaum, 2015/03/08
- [Qemu-devel] [PATCH v4 for-2.3 01/25] acpi: fix aml_equal term implementation, Marcel Apfelbaum, 2015/03/08
- [Qemu-devel] [PATCH v4 for-2.3 02/25] acpi: add aml_or() term, Marcel Apfelbaum, 2015/03/08
- Re: [Qemu-devel] [PATCH v4 for-2.3 02/25] acpi: add aml_or() term,
Shannon Zhao <=
- [Qemu-devel] [PATCH v4 for-2.3 03/25] acpi: add aml_add() term, Marcel Apfelbaum, 2015/03/08
- [Qemu-devel] [PATCH v4 for-2.3 04/25] acpi: add aml_lless() term, Marcel Apfelbaum, 2015/03/08
- [Qemu-devel] [PATCH v4 for-2.3 06/25] acpi: add aml_shiftleft() term, Marcel Apfelbaum, 2015/03/08
- [Qemu-devel] [PATCH v4 for-2.3 05/25] acpi: add aml_index() term, Marcel Apfelbaum, 2015/03/08
- [Qemu-devel] [PATCH v4 for-2.3 07/25] acpi: add aml_shiftright() term, Marcel Apfelbaum, 2015/03/08