Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

[Alexander Graf]

> Am 09.03.2015 um 23:44 schrieb Alexey Kardashevskiy <address@hidden>:
> 
>> On 03/10/2015 02:58 PM, David Gibson wrote:
>>> On Tue, Mar 10, 2015 at 02:52:48PM +1100, Alexey Kardashevskiy wrote:
>>>> On 03/10/2015 01:39 AM, Alexey Kardashevskiy wrote:
>>>>> On 03/09/2015 11:31 PM, Alexander Graf wrote:
>>>>> 
>>>>> 
>>>>>> On 02.03.15 00:46, Alexey Kardashevskiy wrote:
>>>>>> This removes floppy disks support as it is not supported by any PPC64
>>>>>> system anyway as the only way to have floppy disk on such systems would
>>>>>> be an ISA bus and Linux kernels seems have never had such support.
>>>>>> 
>>>>>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>>>>> 
>>>>> I removed this patch from my queue again. The ppc64-softmmu target can
>>>>> execute -M PReP which in turn uses the fdc.
>>>> 
>>>> 
>>>> Out of curiosity - do you have actual 64bit guests being able to run on
>>>> PReP? :) Current Linux ditched its support...
>>> 
>>> 
>>> Paul suggested that there has never ever been a 64bit PReP CPU so there is
>>> no point in emulating it in QEMU. Or there is some reason for that?
>> 
>> IIUC, qemu-system-ppc64 (roughly speaking) emulates a superset of what
>> qemu-system-ppc does, not a different set of hardware.
> 
> Well, default-configs/ppc-softmmu.mak does not include 
> default-configs/ppc64-softmmu.mak or vice versa so I would say these are 
> pretty independent and I would simply remove CONFIG_PREP* from 
> default-configs/ppc64-softmmu.mak.

Convention so far has been that ppc64 includes ppc includes ppcemb. I don't see 
why we should break that assumption.

However I do agree that we should probably reflect it with includes in the mak 
files.


Alex

> 
> 
> -- 
> Alexey