Re: [Qemu-devel] [PATCH] cris: remove unused cris_cond15 declarations

[Stefan Weil]

Am 10.03.2015 um 06:40 schrieb Michael Tokarev:
> Signed-off-by: Michael Tokarev <address@hidden>
> ---
>   disas/cris.c              | 11 -----------
>   target-cris/opcode-cris.h | 10 ----------
>   2 files changed, 21 deletions(-)
>
> diff --git a/disas/cris.c b/disas/cris.c
> index 9dfb4e3..0fc7e54 100644
> --- a/disas/cris.c
> +++ b/disas/cris.c
> @@ -1214,17 +1214,6 @@ cris_cc_strings[] =
>     "wf"
>   };
>   
> -/* Different names and semantics for condition 1111 (0xf).  */
> -const struct cris_cond15 cris_cond15s[] =
> -{
> -  /* FIXME: In what version did condition "ext" disappear?  */
> -  {"ext", cris_ver_v0_3},
> -  {"wf", cris_ver_v10},
> -  {"sb", cris_ver_v32p},
> -  {NULL, 0}
> -};
> -
> -
>   /*
>    * Local variables:
>    * eval: (c-set-style "gnu")
> diff --git a/target-cris/opcode-cris.h b/target-cris/opcode-cris.h
> index 779d4aa..e7ebb98 100644
> --- a/target-cris/opcode-cris.h
> +++ b/target-cris/opcode-cris.h
> @@ -108,16 +108,6 @@ struct cris_support_reg
>   };
>   extern const struct cris_support_reg cris_support_regs[];
>   
> -struct cris_cond15
> -{
> -  /* The name of the condition.  */
> -  const char *const name;
> -
> -  /* What CPU version this condition name applies to.  */
> -  enum cris_insn_version_usage applicable_version;
> -};
> -extern const struct cris_cond15 cris_conds15[];
> -
>   /* Opcode-dependent constants.  */
>   #define AUTOINCR_BIT (0x04)

Reviewed-by: Stefan Weil <address@hidden>

There remains a comment in disas/cris.c referring to cris_conds15. Maybe you
want to add that to your patch, too (keep my review then).