[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library |
Date: |
Tue, 10 Mar 2015 17:17:59 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, 03/10 09:50, Kevin Wolf wrote:
> Am 10.03.2015 um 08:06 hat Michael Tokarev geschrieben:
> > block/dmg can use additional library (libbz2) to read
> > bzip2-compressed files. Make the block driver to be
> > a module if libbz2 support is requested, to avoid extra
> > library dependency by default.
> >
> > Signed-off-by: Michael Tokarev <address@hidden>
>
> First of all: I don't think this is suitable for trivial. The actual
> code change might be small, but the change in behaviour is important and
> needs discussion.
>
> > This might be questionable, to make the thing to be either
> > module or built-in depending on build environment, so a
> > better idea may be to make it modular unconditionally.
> > This block device format isn't used often.
>
> Yes, I'm concerned that making it conditional might be a bit surprising.
> I'd like to hear some more opinions before applying this.
I don't see the advantage over making it an unconditional module - condition
only makes it a bit more complicated.
>
> Also, should we consider making some more rarely used image formats
> modules even if they don't pull in external dependencies?
Sounds reasonable to me. Is the intention to reduce binary size?
Fam
- [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library, Michael Tokarev, 2015/03/10
- Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library, Kevin Wolf, 2015/03/10
- Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library,
Fam Zheng <=
- Re: [Qemu-devel] [Qemu-block] [PATCH] block/dmg: make it modular if using additional library, Stefan Hajnoczi, 2015/03/10
- Re: [Qemu-devel] [Qemu-block] [PATCH] block/dmg: make it modular if using additional library, Michael Tokarev, 2015/03/10
- Re: [Qemu-devel] [Qemu-block] [PATCH] block/dmg: make it modular if using additional library, Kevin Wolf, 2015/03/10
- Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library, Michael Tokarev, 2015/03/10
- Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library, Stefan Hajnoczi, 2015/03/11
- Re: [Qemu-devel] [Qemu-block] [PATCH] block/dmg: make it modular if using additional library, Stefan Hajnoczi, 2015/03/11