[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 03/45] qemu_ram_foreach_block: pass up error
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 03/45] qemu_ram_foreach_block: pass up error value, and down the ramblock name |
|
Date: |
Tue, 10 Mar 2015 16:21:44 +0000 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
* Eric Blake (address@hidden) wrote:
> On 02/25/2015 09:51 AM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> >
> > check the return value of the function it calls and error if it's non-0
> > Fixup qemu_rdma_init_one_block that is the only current caller,
> > and __qemu_rdma_add_block the only function it calls using it.
>
> Should we also be changing the name of __qemu_rdma_add_block to get rid
> of the wrong use of the reserved leading __ namespace?
I already did that in ba795761857082a9bb8c4be1f28e7cdd82f039b0 that
got merged after I cut this patch.
Dave
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK