qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 0/2] virtio len fixes for qemu.


From: Rusty Russell
Subject: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu.
Date: Wed, 11 Mar 2015 16:29:30 +1030

The virtio 'used' ring describes descriptors which have been used.  It
also says how many bytes have been written to the ring.  For some cases,
this value is ignored by Linux guests, thus errors have not been noticed.
I was working on increasing the checking in Linux when I noticed this
behaviour.

The first patch changes the 'len' formal parameter name to 'len_written' to
make the API clearer, and adds an assert(). The second fixes block writes.

Cheers,
Rusty.
PS.  It's based on MST's virtio-1.0 tree, but should be easily ported.

Rusty Russell (2):
  virtio: make it clear that "len" for a used descriptor is len written.
  virtio-blk: fix length calculations for write operations.

 hw/block/virtio-blk.c      |  9 ++++++++-
 hw/virtio/virtio.c         | 19 ++++++++++++-------
 include/hw/virtio/virtio.h |  4 ++--
 3 files changed, 22 insertions(+), 10 deletions(-)

-- 
2.1.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]