[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 0/4] Convert 'status' of MigrationInfo from o

From: zhanghailiang
Subject: Re: [Qemu-devel] [PATCH v4 0/4] Convert 'status' of MigrationInfo from open-coded 'str' to enum type
Date: Thu, 12 Mar 2015 09:06:45 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.1.1


Should this series be merged in 2.3 version? I noticed that 3.17 is hardfreeze 

On 2015/3/9 14:45, zhanghailiang wrote:

This series converts open-coded 'str' type to enum type for 'status'.

This conversion will be more convenient for future extensibility.
Actually, I will add a MIG_STATE_COLO state for COLO, and i also
saw Dave added MIG_STATE_POSTCOPY_ACTIVE for postcopy.

Patch 1 and 2 are preparation for the conversion, patch 3 completes the 
Besides, i add a additional patch (patch 4) to expose 'cancelling' to user,
it will influence libvirt side. And i have CC libvirt development.

One more thing, i have to replace MIG_STATE_ERROR with MIGRATION_STATUS_FAILED,
and it begin from 0, not its original -1. I think it has no side effect.

Please review.

- Rename _ERROR to _FAILED in patch 1 instead of patch 4 (Eric)
- Add Reviewd-by for patch 2 and 4
- Fix some grammar in commit message of patch 4 (Eric)

- Use longer name for Migration status macro. (Eric Blake)
- Rename internal-only typename 'MigrationStatus' (Eric, Dave, Markus)
- Expose 'cancelling' state (Eric Blake)

- Remove '(since xyz)' strings. (Eric Blake)

Thanks for their comments. ;)

zhanghailiang (4):
   migration: Rename abbreviated macro MIG_STATE_* to
   hmp: Rename 'MigrationStatus' to 'HMPMigrationStatus'
   migration: Convert 'status' of MigrationInfo to use an enum type
   migration: Expose 'cancelling' status to user

  hmp.c                 | 15 ++++----
  migration/migration.c | 95 ++++++++++++++++++++++++---------------------------
  qapi-schema.json      | 34 +++++++++++++++---
  3 files changed, 81 insertions(+), 63 deletions(-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]