[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/9] qom: Implement qom-list HMP command
From: |
Gonglei |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/9] qom: Implement qom-list HMP command |
Date: |
Fri, 13 Mar 2015 09:32:02 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 2015/3/13 0:43, Andreas Färber wrote:
> Implement it as a wrapper for QMP qom-list, but mimic the behavior of
> scripts/qmp/qom-list in making the path argument optional and listing
> the root if absent, to hint users what kind of path to pass.
>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
> hmp-commands.hx | 13 +++++++++++++
> hmp.c | 26 ++++++++++++++++++++++++++
> hmp.h | 1 +
> 3 files changed, 40 insertions(+)
>
Reviewed-by: Gonglei <address@hidden>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index d5022d8..c3b93d6 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1658,6 +1658,19 @@ Add CPU with id @var{id}
> ETEXI
>
> {
> + .name = "qom-list",
> + .args_type = "path:s?",
> + .params = "path",
> + .help = "list QOM properties",
> + .mhandler.cmd = hmp_qom_list,
> + },
> +
> +STEXI
> address@hidden qom-list address@hidden
> +Print QOM properties of object at location @var{path}
> +ETEXI
> +
> + {
> .name = "info",
> .args_type = "item:s?",
> .params = "[subcommand]",
> diff --git a/hmp.c b/hmp.c
> index 71c28bc..f6df075 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1852,3 +1852,29 @@ void hmp_info_memory_devices(Monitor *mon, const QDict
> *qdict)
>
> qapi_free_MemoryDeviceInfoList(info_list);
> }
> +
> +void hmp_qom_list(Monitor *mon, const QDict *qdict)
> +{
> + const char *path = qdict_get_try_str(qdict, "path");
> + ObjectPropertyInfoList *list;
> + Error *err = NULL;
> +
> + if (path == NULL) {
> + monitor_printf(mon, "/\n");
> + return;
> + }
> +
> + list = qmp_qom_list(path, &err);
> + if (err == NULL) {
> + ObjectPropertyInfoList *start = list;
> + while (list != NULL) {
> + ObjectPropertyInfo *value = list->value;
> +
> + monitor_printf(mon, "%s (%s)\n",
> + value->name, value->type);
> + list = list->next;
> + }
> + qapi_free_ObjectPropertyInfoList(start);
> + }
> + hmp_handle_error(mon, &err);
> +}
> diff --git a/hmp.h b/hmp.h
> index 81177b2..18c0f52 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -95,6 +95,7 @@ void hmp_object_add(Monitor *mon, const QDict *qdict);
> void hmp_object_del(Monitor *mon, const QDict *qdict);
> void hmp_info_memdev(Monitor *mon, const QDict *qdict);
> void hmp_info_memory_devices(Monitor *mon, const QDict *qdict);
> +void hmp_qom_list(Monitor *mon, const QDict *qdict);
> void object_add_completion(ReadLineState *rs, int nb_args, const char *str);
> void object_del_completion(ReadLineState *rs, int nb_args, const char *str);
> void device_add_completion(ReadLineState *rs, int nb_args, const char *str);
>
- [Qemu-devel] [PATCH v2 0/9] qom: HMP commands to supersede info qtree, Andreas Färber, 2015/03/12
- [Qemu-devel] [PATCH v2 1/9] scripts: Add qom-tree script, Andreas Färber, 2015/03/12
- [Qemu-devel] [PATCH v2 3/9] qom: Implement qom-set HMP command, Andreas Färber, 2015/03/12
- [Qemu-devel] [PATCH v2 5/9] qapi: Stub out StringOutputVisitor struct support, Andreas Färber, 2015/03/12
- [Qemu-devel] [PATCH v2 4/9] qom: Implement info qom-tree HMP command, Andreas Färber, 2015/03/12
- [Qemu-devel] [PATCH v2 9/9] qdev: Move owner-less IRQs to /machine/unattached, Andreas Färber, 2015/03/12
- [Qemu-devel] [PATCH v2 2/9] qom: Implement qom-list HMP command, Andreas Färber, 2015/03/12
- Re: [Qemu-devel] [PATCH v2 2/9] qom: Implement qom-list HMP command,
Gonglei <=
- [Qemu-devel] [PATCH v2 7/9] qom: Add verbose option to info qom-tree HMP command, Andreas Färber, 2015/03/12
- [Qemu-devel] [PATCH v2 6/9] qom: Implement qom-get HMP command, Andreas Färber, 2015/03/12
- [Qemu-devel] [PATCH v2 8/9] memory: Move owner-less MemoryRegions to /machine/unattached, Andreas Färber, 2015/03/12
- Re: [Qemu-devel] [PATCH v2 0/9] qom: HMP commands to supersede info qtree, Gonglei, 2015/03/12
- Re: [Qemu-devel] [PATCH v2 0/9] qom: HMP commands to supersede info qtree, Markus Armbruster, 2015/03/17
- Re: [Qemu-devel] [PATCH v2 0/9] qom: HMP commands to supersede info qtree, Andreas Färber, 2015/03/17