Re: [Qemu-devel] [PATCH 0/2] target-i386: Haswell-noTSX and Broadwell-noTSX CPU models

[Andreas Färber]

Am 13.03.2015 um 20:09 schrieb Eduardo Habkost:
> With the Intel microcode update that removed HLE and RTM, there will be
> different kinds of Haswell and Broadwell CPUs out there: some that still
> have the HLE and RTM features, and some that don't have the HLE and RTM
> features. On both cases people may be willing to use the pc-*-2.3
> machine-types.
> 
> So instead of making the CPU model results confusing by making it depend on 
> the
> machine-type, keep HLE and RTM on the existing Haswell and Broadwell CPU
> models, and introduce "Haswell-noTSX" and "Broadwell-noTSX" CPU models later,
> for people who have CPUs that don't have TSX feature available.
> 
> Eduardo Habkost (2):
>   Revert "target-i386: Disable HLE and RTM on Haswell & Broadwell"
>   target-i386: Haswell-noTSX and Broadwell-noTSX

No objections from a generic CPU point of view.

Only thing that comes to mind is whether it might make sense to
hierarchically make Broadwell the parent type of Broadwell-noTSX, to
avoid duplication. But then again we already have a lot of it. ;)

Regards,
Andreas

>  hw/i386/pc_piix.c |  4 ---
>  hw/i386/pc_q35.c  |  4 ---
>  target-i386/cpu.c | 74 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++--
>  3 files changed, 72 insertions(+), 10 deletions(-)

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)