[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/7] vmxnet: Remove unused function vmxnet_rx
From: |
Dmitry Fleytman |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/7] vmxnet: Remove unused function vmxnet_rx_pkt_get_num_frags() |
Date: |
Sat, 14 Mar 2015 09:35:03 +0200 |
Looks good. Thanks.
> On Mar 14, 2015, at 08:19, Thomas Huth <address@hidden> wrote:
>
> The function is not used anymore and thus can be deleted.
>
> Signed-off-by: Thomas Huth <address@hidden>
> Cc: Dmitry Fleytman <address@hidden>
> ---
> hw/net/vmxnet_rx_pkt.c | 7 -------
> hw/net/vmxnet_rx_pkt.h | 9 ---------
> 2 files changed, 0 insertions(+), 16 deletions(-)
>
> diff --git a/hw/net/vmxnet_rx_pkt.c b/hw/net/vmxnet_rx_pkt.c
> index a40e346..acbca6a 100644
> --- a/hw/net/vmxnet_rx_pkt.c
> +++ b/hw/net/vmxnet_rx_pkt.c
> @@ -172,13 +172,6 @@ bool vmxnet_rx_pkt_has_virt_hdr(struct VmxnetRxPkt *pkt)
> return pkt->has_virt_hdr;
> }
>
> -uint16_t vmxnet_rx_pkt_get_num_frags(struct VmxnetRxPkt *pkt)
> -{
> - assert(pkt);
> -
> - return pkt->vec_len;
> -}
> -
> uint16_t vmxnet_rx_pkt_get_vlan_tag(struct VmxnetRxPkt *pkt)
> {
> assert(pkt);
> diff --git a/hw/net/vmxnet_rx_pkt.h b/hw/net/vmxnet_rx_pkt.h
> index 6b2c60e..5f8352a 100644
> --- a/hw/net/vmxnet_rx_pkt.h
> +++ b/hw/net/vmxnet_rx_pkt.h
> @@ -114,15 +114,6 @@ bool vmxnet_rx_pkt_is_vlan_stripped(struct VmxnetRxPkt
> *pkt);
> bool vmxnet_rx_pkt_has_virt_hdr(struct VmxnetRxPkt *pkt);
>
> /**
> - * returns number of frags attached to the packet
> - *
> - * @pkt: packet
> - * @ret: number of frags
> - *
> - */
> -uint16_t vmxnet_rx_pkt_get_num_frags(struct VmxnetRxPkt *pkt);
> -
> -/**
> * attach data to rx packet
> *
> * @pkt: packet
> --
> 1.7.1
>
- [Qemu-devel] [PATCH v2 0/7] Remove more unused functions, Thomas Huth, 2015/03/14
- [Qemu-devel] [PATCH v2 4/7] monitor: Remove unused functions, Thomas Huth, 2015/03/14
- [Qemu-devel] [PATCH v2 2/7] vmxnet: Remove unused function vmxnet_rx_pkt_get_num_frags(), Thomas Huth, 2015/03/14
- Re: [Qemu-devel] [PATCH v2 2/7] vmxnet: Remove unused function vmxnet_rx_pkt_get_num_frags(),
Dmitry Fleytman <=
- [Qemu-devel] [PATCH v2 1/7] migration: Remove unused functions, Thomas Huth, 2015/03/14
- [Qemu-devel] [PATCH v2 6/7] util: Remove unused functions, Thomas Huth, 2015/03/14
- [Qemu-devel] [PATCH v2 3/7] pci: Remove unused function ich9_d2pbr_init(), Thomas Huth, 2015/03/14
- [Qemu-devel] [PATCH v2 5/7] usb: Remove unused functions, Thomas Huth, 2015/03/14
- [Qemu-devel] [PATCH v2 7/7] Remove various unused functions, Thomas Huth, 2015/03/14