[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity
From: |
Shannon Zhao |
Subject: |
Re: [Qemu-devel] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity |
Date: |
Sat, 14 Mar 2015 17:15:23 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 2015/3/14 14:57, Stefan Weil wrote:
> Am 14.03.2015 um 04:42 schrieb Shannon Zhao:
>> Free data in function sdp_attr_write after use.
>>
>> Signed-off-by: Shannon Zhao <address@hidden>
>> Signed-off-by: Shannon Zhao <address@hidden>
>> ---
>> hw/bt/sdp.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/bt/sdp.c b/hw/bt/sdp.c
>> index 218e075..8e6d5e3 100644
>> --- a/hw/bt/sdp.c
>> +++ b/hw/bt/sdp.c
>> @@ -735,6 +735,7 @@ static void sdp_service_record_build(struct
>> sdp_service_record_s *record,
>> record->attribute_list[record->attributes ++].len = len;
>> data += len;
>> }
>> + g_free(data);
>
> No, here more work is needed. data is no longer the original data,
> because two lines above it is modified.
Thanks for pointing out.
>
>> /* Sort the attribute list by the AttributeID */
>> qsort(record->attribute_list, record->attributes,
>
>
> .
>
- [Qemu-devel] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity, Shannon Zhao, 2015/03/13
- [Qemu-devel] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity, Shannon Zhao, 2015/03/14
- Re: [Qemu-devel] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity, Stefan Weil, 2015/03/14
- Re: [Qemu-devel] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity, Paolo Bonzini, 2015/03/15
- Re: [Qemu-devel] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity, Michael Tokarev, 2015/03/15
- Re: [Qemu-devel] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity, Paolo Bonzini, 2015/03/15
- Re: [Qemu-devel] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity, Markus Armbruster, 2015/03/16
- Re: [Qemu-devel] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity, Paolo Bonzini, 2015/03/16