[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

From: Chen, Tiejun
Subject: Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind
Date: Mon, 16 Mar 2015 09:07:30 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 2015/3/13 18:11, Ian Campbell wrote:
On Fri, 2015-03-13 at 09:39 +0800, Chen, Tiejun wrote:
I don't think you can abort here, since a user can set
b_info->u.hvm.gfx_passthru_kind to default. You would need to
return an error.

Then, looks I should do this,

LOG(ERROR, "No supported IGD to passthru," " or please force set
gfx_passthru=\"igd\".\n"); return NULL;

If I remember the context correctly this is in the autodetect case,
so I think shouldn't mention IGD. Something like "Unable to detect
graphics passthru kind, please set gfx_passthru_kind. See xl.cfg(5)
for more

s/gfx_passthru_kind/gfx_passthru, right? Because actually we always get
'gfx_passthru_kind' from 'gfx_passthru'.


@@ -720,6 +720,13 @@ void libxl_mac_copy(libxl_ctx *ctx,
libxl_mac *dst, libxl_mac *src);


/* * libxl_domain_build_info has the u.hvm.gfx_passthru_kind field
and * the libxl_gfx_passthru_kind enumeration is defined. */ #define

Users don't care about the internal details, just about the existence
of the support.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]