qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] block/throttle: Use host clock type


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH] block/throttle: Use host clock type
Date: Mon, 16 Mar 2015 17:08:52 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Am 13.03.2015 um 07:35 hat Fam Zheng geschrieben:
> Throttle timers won't make any progress when VCPU is not running, which
> is prone to stall the request queue in cases like utils, qtest,
> suspending, and live migration, unless carefully handled. What we do now
> is crude. For example in bdrv_drain_all, requests are resumed
> immediately without consulting throttling timer. Unfortunately
> bdrv_drain_all is so widely used that there may be too many holes that
> guest could bypass throttling.
> 
> If we use the host clock, we can just trust the nested poll when waiting
> for requests.
> 
> Signed-off-by: Fam Zheng <address@hidden>

This breaks qemu-iotests 093. Dropped it again from the block branch.

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]