[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 11/19] nbd: Fix interpretation of the export flags

From: Paolo Bonzini
Subject: [Qemu-devel] [PULL 11/19] nbd: Fix interpretation of the export flags
Date: Wed, 18 Mar 2015 12:24:58 +0100

From: Max Reitz <address@hidden>

The export flags are a 16 bit value, so be16_to_cpu() has to be used to
interpret them correctly. This makes discard and flush actually work
for named NBD exports (they did not work before, because the client
always assumed them to be unsupported because of the bug fixed by this

Signed-off-by: Max Reitz <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
 nbd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nbd.c b/nbd.c
index fb8a4d4..563e820 100644
--- a/nbd.c
+++ b/nbd.c
@@ -625,7 +625,7 @@ int nbd_receive_negotiate(int csock, const char *name, 
uint32_t *flags,
             error_setg(errp, "Failed to read export flags");
             goto fail;
-        *flags |= be32_to_cpu(tmp);
+        *flags |= be16_to_cpu(tmp);
     if (read_sync(csock, &buf, 124) != 124) {
         error_setg(errp, "Failed to read reserved block");

reply via email to

[Prev in Thread] Current Thread [Next in Thread]