[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/9] vnc: Fix QMP change not to use funky error class
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 1/9] vnc: Fix QMP change not to use funky error class |
Date: |
Wed, 18 Mar 2015 14:17:38 +0100 |
From: Markus Armbruster <address@hidden>
Error classes are a leftover from the days of "rich" error objects.
New code should always use ERROR_CLASS_GENERIC_ERROR. Commit 1d0d59f
added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it.
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/vnc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 6f9b718..a950016 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3594,7 +3594,7 @@ void vnc_display_open(const char *id, Error **errp)
dev = qdev_find_recursive(sysbus_get_default(), device_id);
if (dev == NULL) {
- error_set(errp, QERR_DEVICE_NOT_FOUND, device_id);
+ error_setg(errp, "Device '%s' not found", device_id);
goto fail;
}
--
1.8.3.1
- [Qemu-devel] [PULL for-2.3 0/9] vnc patch queue., Gerd Hoffmann, 2015/03/18
- [Qemu-devel] [PULL 1/9] vnc: Fix QMP change not to use funky error class,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 8/9] ui: remove separate gnutls_session for websockets server, Gerd Hoffmann, 2015/03/18
- [Qemu-devel] [PULL 7/9] ui: enforce TLS when using websockets server, Gerd Hoffmann, 2015/03/18
- [Qemu-devel] [PULL 3/9] ui: replace printf() calls with VNC_DEBUG, Gerd Hoffmann, 2015/03/18
- [Qemu-devel] [PULL 6/9] ui: fix setup of VNC websockets auth scheme with TLS, Gerd Hoffmann, 2015/03/18
- [Qemu-devel] [PULL 5/9] ui: split setup of VNC auth scheme into separate method, Gerd Hoffmann, 2015/03/18
- [Qemu-devel] [PULL 9/9] ui: ensure VNC websockets server checks the ACL if requested, Gerd Hoffmann, 2015/03/18
- [Qemu-devel] [PULL 4/9] ui: report error if user requests VNC option that is unsupported, Gerd Hoffmann, 2015/03/18
- [Qemu-devel] [PULL 2/9] ui: remove unused 'wiremode' variable in VncState struct, Gerd Hoffmann, 2015/03/18
- Re: [Qemu-devel] [PULL for-2.3 0/9] vnc patch queue., Peter Maydell, 2015/03/19