[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] block: allow BLOCK_IMAGE_CORRUPTED to have

From: Alberto Garcia
Subject: Re: [Qemu-devel] [PATCH 3/3] block: allow BLOCK_IMAGE_CORRUPTED to have a node name
Date: Thu, 19 Mar 2015 23:04:57 +0100
User-agent: Mutt/1.5.20 (2009-06-14)

On Thu, Mar 19, 2015 at 05:52:52PM -0400, Max Reitz wrote:

> So in this case here I don't really see a benefit of reusing @device
> instead of just adding @node-name, whereas adding @node-name will
> have the benefit of not affecting anybody and (in my opinion) being
> more explicit. However, if others tend to think otherwise (the
> @node-name vs. @node vs. @device is a constant point of dissent
> over naming...), I'm happy to be convinced otherwise. In the end it
> doesn't really matter after all, it's a machine-readable protocol.
> If software can work with it, it's fine.

It's fine with me as well, I just had the impression that there was a
consensus towards not extending the API if possible, but in my case
I'm happy to implement whichever alternative.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]