[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

From: Chen, Tiejun
Subject: Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind
Date: Fri, 20 Mar 2015 18:20:35 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 2015/3/20 18:11, Ian Campbell wrote:
On Fri, 2015-03-20 at 18:08 +0800, Chen, Tiejun wrote:
+        if (!xlu_cfg_get_string(config, "gfx_passthru_kind", &buf, 0)) {
+            if (libxl_gfx_passthru_kind_from_string(buf,
&b_info->u.hvm.gfx_passthru_kind)) {
+                fprintf(stderr,
+                        "ERROR: invalid value \"%s\" for
+                        buf);
+                exit (1);
+            }
+        }

This unnecessary bit seems to have crept back in.

Sorry to hit this again when I address other comments.

Don't forget to update the manpages if you haven't already.

Looks I need to update docs/man/xl.cfg.pod.5.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]