[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vT

From: Stefan Berger
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine
Date: Fri, 20 Mar 2015 08:00:47 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 03/19/2015 09:35 PM, Xu, Quan wrote:

-----Original Message-----
From: Ian Campbell [mailto:address@hidden
Sent: Thursday, March 19, 2015 8:57 PM
To: Xu, Quan
Cc: address@hidden; address@hidden; address@hidden;
address@hidden; address@hidden
Subject: Re: [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for
HVM virtual machine

On Tue, 2015-03-10 at 08:16 -0400, Quan Xu wrote:
@@ -151,6 +152,8 @@ device_hardware_setup(void)
+    if (runningOnXen())
+        vtpm4hvm_setup();
Is there anything which is actually Xen specific about the driver in tpm.[ch]?
Would it be better to just probe for it, perhaps gates by a Kconfig option which
enables TPM support.

And following that train of thought I think you could reasonable drop "4hvm"
from the name. And possibly even the leading "v", since I suppose seabios
shouldn't really care if the tpm is emulated or real so long as it looks like a 

Thanks for your review. Make sense.


From previously posted patches you should be able to take 1/8 with the driver:


2/8 added ACPI support, but this is not necessary; it contained the probing parts, which could be merged into 1.

3/8 was doing TPM initialization, so that should be recyclable as well: http://www.seabios.org/pipermail/seabios/2014-July/008180.html

I have a set of patches that removes the ACPI part in 2/8, though didn't post it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]