Re: [Qemu-devel] [PATCH v4 20/20] iotests: add incremental backup failure recovery test

[Max Reitz]

On 2015-03-20 at 15:17, John Snow wrote:
> Test the failure case for incremental backups.
>
> Signed-off-by: John Snow <address@hidden>
> ---
>   blockdev.c                 |  1 -
>   tests/qemu-iotests/124     | 55 ++++++++++++++++++++++++++++++++++++++++++++++
>   tests/qemu-iotests/124.out |  4 ++--
>   3 files changed, 57 insertions(+), 3 deletions(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index b9c79ed..ab67b4d 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -1218,7 +1218,6 @@ static BdrvDirtyBitmap *block_dirty_bitmap_lookup(const 
> char *node,
>       } else {
>           aio_context_release(aio_context);
>       }
> -
>       return bitmap;
>   
>    fail:

This doesn't look like it belongs here...

With that hunk removed (whether by maintainer or by you):

Reviewed-by: Max Reitz <address@hidden>