[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6 v7] target-tilegx: Firstly add TILE-Gx with
Re: [Qemu-devel] [PATCH 1/6 v7] target-tilegx: Firstly add TILE-Gx with minimized features
Sat, 21 Mar 2015 06:52:13 +0800
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
On 3/21/15 01:48, Peter Maydell wrote:
> On 20 March 2015 at 15:25, Chen Gang <address@hidden> wrote:
>> It is the configure and build system support for TILE-Gx (tilegx will be
>> used in configure and real sub-directory name).
>> At present, it is linux-user only, and can finish the first system call
>> (uname) execution in __libc_start_main().
>> Signed-off-by: Chen Gang <address@hidden>
>> configure | 3 +
>> default-configs/tilegx-linux-user.mak | 1 +
>> target-tilegx/Makefile.objs | 1 +
>> target-tilegx/cpu-qom.h | 73 ++
>> target-tilegx/cpu.c | 149 +++
>> target-tilegx/cpu.h | 94 ++
>> target-tilegx/helper.c | 31 +
>> target-tilegx/helper.h | 1 +
>> target-tilegx/opcode_tilegx.h | 1406 ++++++++++++++++++++++++++
>> target-tilegx/translate.c | 1764
>> 10 files changed, 3523 insertions(+)
> If you have any patch which has a diffstat like this then
> you *must* split it up into separate patches. Even
> 1000 lines is really too long to be easily
> reviewable, and this patch is now over three times
> that size! Most patches should be 250 lines or
> less, really, unless they're very mechanical.
OK, thanks. I shall try to split it into 3 patches in patch v8.
Open, share, and attitude like air, water, and life which God blessed