[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/5] fw_cfg: insert fw_cfg file blobs via qem
Gabriel L. Somlo
Re: [Qemu-devel] [PATCH v3 5/5] fw_cfg: insert fw_cfg file blobs via qemu cmdline
Mon, 23 Mar 2015 09:19:52 -0400
On Mon, Mar 23, 2015 at 09:48:52AM +0100, Laszlo Ersek wrote:
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index 319d971..138b9cd 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -2668,6 +2668,17 @@ STEXI
> > @table @option
> > ETEXI
> > +DEF("fw_cfg", HAS_ARG, QEMU_OPTION_fwcfg,
> > + "-fw_cfg name=<name>,file=<file>\n"
> I guess I should have pointed this out earlier -- you could have
> bracketed the "name=" part, to communicate that "name" is
> Anyway, don't respin just because of this.
Well, this *should* go in, aesthetics are important to me too :)
If I get more feedback, I'll work this into a v4 of the series.
However, if this is it, and everything is OK otherwise, what's the
standard procedure for fixing just this one minor item ? Do I still
send out a v4, or is this something the maintainer ultimately applying
the patch would rather do themselves ?
[Qemu-devel] [PATCH v3 4/5] fw_cfg: prohibit insertion of duplicate fw_cfg file names, Gabriel L. Somlo, 2015/03/21