[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/4] configure: factor out supported flag che
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/4] configure: factor out supported flag check |
Date: |
Wed, 25 Mar 2015 13:16:48 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Mar 24, 2015 at 02:19:44PM -0400, John Snow wrote:
> +cc_has_warning_flag() {
> + write_c_skeleton;
> +
> # Use the positive sense of the flag when testing for -Wno-wombat
> # support (gcc will happily accept the -Wno- form of unknown
> # warning options).
> - optflag="$(echo $flag | sed -e 's/^-Wno-/-W/')"
> - if compile_prog "-Werror $optflag" "" ; then
> - QEMU_CFLAGS="$QEMU_CFLAGS $flag"
> + optflag="$(echo $1 | sed -e 's/^-Wno-/-W/')"
> + compile_prog "-Werror $optflag" ""
> +}
> +
> +for flag in $gcc_flags; do
> + if cc_has_warning_flag $flag --keep-tmpc; then
Please drop the unused --keep-tmpc option here.
Stefan
pgp7NHsQiwQu8.pgp
Description: PGP signature