[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.3] mips: memory: Replace memory_region_ini
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH for-2.3] mips: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory |
Date: |
Wed, 25 Mar 2015 14:32:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 25/03/2015 14:23, Leon Alrae wrote:
> On 24/03/2015 23:01, Andreas Färber wrote:
>> Am 24.03.2015 um 22:28 schrieb Dirk Müller:
>>> Commit 0b183fc871:"memory: move mem_path handling to
>>> memory_region_allocate_system_memory" split memory_region_init_ram and
>>> memory_region_init_ram_from_file. Also it moved mem-path handling a step
>>> up from memory_region_init_ram to memory_region_allocate_system_memory.
>>>
>>> Therefore for any board that uses memory_region_init_ram directly,
>>> -mem-path is not supported.
>>>
>>> Fix this by replacing memory_region_init_ram with
>>> memory_region_allocate_system_memory.
>>>
>>> Signed-off-by: Dirk Mueller <address@hidden>
>>> ---
>>> hw/mips/mips_fulong2e.c | 3 +--
>>> hw/mips/mips_jazz.c | 5 ++---
>>> hw/mips/mips_malta.c | 5 ++---
>>> hw/mips/mips_mipssim.c | 5 ++---
>>> hw/mips/mips_r4k.c | 3 +--
>>> 5 files changed, 8 insertions(+), 13 deletions(-)
>>
>> Reviewed-by: Andreas Färber <address@hidden>
>>
>> Leon and Paolo, I assume one of you will be handling this?
>>
>
> Acked-by: Leon Alrae <address@hidden>
>
> Paolo, is this going via your memory API pullreq?
I can include it since you've acked it.
Paolo