[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/7] Bug fix: delete the reader entry after q
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/7] Bug fix: delete the reader entry after queueing an event, not before. |
Date: |
Wed, 25 Mar 2015 16:12:40 +0100 |
ACK.
Reviewed-by: Marc-André Lureau <address@hidden>
On Fri, Mar 13, 2015 at 8:45 PM, Jeremy White <address@hidden> wrote:
> As far as I can tell, the vreader_remove_reader function is not presently in
> use anywhere; I have an upcoming patch set that uses it.
>
> Signed-off-by: Jeremy White <address@hidden>
> ---
> libcacard/vreader.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libcacard/vreader.c b/libcacard/vreader.c
> index 0315dd8..8b10d6a 100644
> --- a/libcacard/vreader.c
> +++ b/libcacard/vreader.c
> @@ -529,8 +529,8 @@ vreader_remove_reader(VReader *reader)
> }
> vreader_dequeue(vreader_list, current_entry);
> vreader_list_unlock();
> - vreader_list_entry_delete(current_entry);
> vevent_queue_vevent(vevent_new(VEVENT_READER_REMOVE, reader, NULL));
> + vreader_list_entry_delete(current_entry);
> return VREADER_OK;
> }
>
> --
> 1.7.10.4
>
>
--
Marc-André Lureau
- Re: [Qemu-devel] [PATCH v3 6/7] Enable support for passthru (e.g. direct to pcsc) smart cards in the emul_options entry point in libcacard., (continued)
- [Qemu-devel] [PATCH v3 3/7] Add a configure check for libpcsclite, and an option to enable or disable it., Jeremy White, 2015/03/13
- [Qemu-devel] [PATCH v3 4/7] Add error checking to vcard_emul_options., Jeremy White, 2015/03/13
- [Qemu-devel] [PATCH v3 5/7] Add a VCARD_DIRECT implemention to the libcacard smartcard support., Jeremy White, 2015/03/13
- [Qemu-devel] [PATCH v3 7/7] Remove the (broken) passthru option., Jeremy White, 2015/03/13
- [Qemu-devel] [PATCH v3 1/7] Bug fix: delete the reader entry after queueing an event, not before., Jeremy White, 2015/03/13
- Re: [Qemu-devel] [PATCH v3 1/7] Bug fix: delete the reader entry after queueing an event, not before.,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v3 2/7] Retrieve the correct TD byte when checking an ATR., Jeremy White, 2015/03/13
- Re: [Qemu-devel] [PATCH v3 0/7] Add support for passthru cards to libcacard, Patchew Tool, 2015/03/13
- Re: [Qemu-devel] [PATCH v3 0/7] Add support for passthru cards to libcacard, Marc-André Lureau, 2015/03/16