[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 0/7] Block Throttle Group Support

From: Alberto Garcia
Subject: Re: [Qemu-devel] [PATCH v4 0/7] Block Throttle Group Support
Date: Fri, 27 Mar 2015 08:23:50 +0100
User-agent: Mutt/1.5.20 (2009-06-14)

On Fri, Mar 27, 2015 at 09:11:19AM +0800, Fam Zheng wrote:

> > Hmm... this actually breaks the new test because now BDS are
> > required to have an AioContext attached when they're added to a
> > group, which doesn't happen in qtest:
> > 
> >     bdrv = bdrv_new();
> >     throttle_group_register_bs(bdrv, "bar");
> > 
> > I'm unsure of how to proceed with this, I don't see a clear way to
> > attach the AioContext here (unless I do bdrv->aio_context = ctx).
> > Suggestions are welcome.
> Use bdrv_attach_aio_context?

That doesn't work in that case, bdrv_attach_aio_context() does nothing
if bdrv->drv is null.

The test works fine if I set bdrv->aio_context directly as I said
above, but is it ok to do that?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]