[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 27/28] qapi: Drop inline nested types in quer

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v5 27/28] qapi: Drop inline nested types in query-pci
Date: Fri, 27 Mar 2015 11:37:43 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Eric Blake <address@hidden> writes:

> A future patch will be using a 'name':{dictionary} entry in the
> QAPI schema to specify a default value for an optional argument;
> but existing use of inline nested structs conflicts with that goal.
> This patch fixes one of only two commands relying on nested
> types, by breaking the nesting into an explicit type; it means
> that the type is now boxed instead of unboxed in C code, but the
> QMP wire format is unaffected by this change.
> Prefer the safer g_new0() while making the conversion, and reduce
> some long lines.
> Signed-off-by: Eric Blake <address@hidden>

Reviewed-by: Markus Armbruster <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]