[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 11/45] Return path: Send responses from desti

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v5 11/45] Return path: Send responses from destination to source
Date: Sat, 28 Mar 2015 16:34:40 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 10/03/2015 06:47, David Gibson wrote:
>> > +void migrate_send_rp_message(MigrationIncomingState *mis,
>> > +                             enum mig_rpcomm_cmd cmd,
>> > +                             uint16_t len, uint8_t *data)
> Using (void *) for data would avoid casts in a bunch of the callers.

Could also use uint8_t in the callers and replace cpu_to_be32 with
stl_be_p.  This makes it harder to send stuff with the wrong endianness.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]