[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/22] memory: add memory_region_ram_resize
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 01/22] memory: add memory_region_ram_resize |
Date: |
Sun, 29 Mar 2015 09:30:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 28/03/2015 19:58, Michael S. Tsirkin wrote:
>> > +void memory_region_ram_resize(MemoryRegion *mr, ram_addr_t newsize, Error
>> > **errp)
>> > +{
>> > + assert(mr->terminates);
> Why? Does "terminates" guarantee that ram_addr
> is valid? In any case, I think this needs a comment.
More or less, but not really; I was just cutting/pasting it from other
functions that use ram_addr. I will clean it up.
Paolo
- [Qemu-devel] [PATCH 00/22] Dirty bitmap atomic access and optimizations, Paolo Bonzini, 2015/03/26
- [Qemu-devel] [PATCH 01/22] memory: add memory_region_ram_resize, Paolo Bonzini, 2015/03/26
- [Qemu-devel] [PATCH 02/22] acpi-build: remove dependency from ram_addr.h, Paolo Bonzini, 2015/03/26
- [Qemu-devel] [PATCH 03/22] memory: the only dirty memory flag for users is DIRTY_MEMORY_VGA, Paolo Bonzini, 2015/03/26
- [Qemu-devel] [PATCH 04/22] display: enable DIRTY_MEMORY_VGA tracking explicitly, Paolo Bonzini, 2015/03/26
- [Qemu-devel] [PATCH 07/22] ui/console: check memory_region_is_logging, Paolo Bonzini, 2015/03/26
- [Qemu-devel] [PATCH 05/22] memory: return bitmap from memory_region_is_logging, Paolo Bonzini, 2015/03/26