[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/7] Convert ffs() != 0 callers to ctz32()
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 3/7] Convert ffs() != 0 callers to ctz32() |
Date: |
Mon, 30 Mar 2015 08:42:28 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 03/17/2015 04:56 AM, Stefan Hajnoczi wrote:
> @@ -1989,8 +1989,7 @@ static void omap_mpuio_write(void *opaque, hwaddr addr,
> case 0x04: /* OUTPUT_REG */
> diff = (s->outputs ^ value) & ~s->dir;
> s->outputs = value;
> - while ((ln = ffs(diff))) {
> - ln --;
> + while ((ln = ctz32(diff)) != 32) {
> if (s->handler[ln])
> qemu_set_irq(s->handler[ln], (value >> ln) & 1);
> diff &= ~(1 << ln);
Surely
while (diff != 0) {
ln = ctz32(diff);
...
}
would be a better conversion.
r~
- [Qemu-devel] [PATCH 0/7] Convert ffs(3) to ctz32(), Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH 1/7] bt-sdp: fix broken uuids power-of-2 calculation, Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH 6/7] os-win32: drop ffs(3) prototype, Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH 4/7] sd: convert sd_normal_command() ffs(3) call to ctz32(), Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH 3/7] Convert ffs() != 0 callers to ctz32(), Stefan Hajnoczi, 2015/03/17
- Re: [Qemu-devel] [PATCH 3/7] Convert ffs() != 0 callers to ctz32(),
Richard Henderson <=
- [Qemu-devel] [PATCH 7/7] checkpatch: complain about ffs(3) calls, Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH 5/7] omap_intc: convert ffs(3) to ctz32() in omap_inth_sir_update(), Stefan Hajnoczi, 2015/03/17
- [Qemu-devel] [PATCH 2/7] Convert (ffs(val) - 1) to ctz32(val), Stefan Hajnoczi, 2015/03/17
- Re: [Qemu-devel] [PATCH 0/7] Convert ffs(3) to ctz32(), Stefan Hajnoczi, 2015/03/17