[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/5] qapi: Clean up documentation of alternate m

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 2/5] qapi: Clean up documentation of alternate mappings
Date: Mon, 30 Mar 2015 09:54:36 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 03/27/2015 05:02 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>> QObject is an internal coding concept and requires the reader to
>> reverse engineer the mapping; it is nicer to be explicit and call
>> out specific JSON types.

>> +for QMP, instead appearing only in the generated C code.  Rather, the
>> +first byte of the value on the wire serves an implicit discriminator:
> I think "first byte of" is implementation detail, and should be left
> out.

Sure; sounds better and shorter.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]