[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] prep: Use MachineClass callbacks for "irq"
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] prep: Use MachineClass callbacks for "irq" and "pic" hmp commands |
Date: |
Mon, 30 Mar 2015 23:25:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
Am 06.03.2015 um 05:18 schrieb David Gibson:
> Currently all ppc targets rely on fallback code in monitor.c to implement
> the "irq" and "pic" hmp commands, by calling into the i8259 code. For the
> PReP machine type, which does usually have an ISA bridge and legacy IO,
> including an i8259, this patch correctly sets the MachineClass callbacks
> to implement those commands properly without the fallback.
>
> In fact PReP is the only ppc machine for which the i8259 implementation
> of those hmp commands makes sense. The other machine types won't typically
> have an i8259 at all. So we can remove the fallback case from the monitor
> meaning that other ppc targets will correctly implement those commands
> as no-ops.
>
> Signed-off-by: David Gibson <address@hidden>
> ---
> hw/ppc/prep.c | 2 ++
> monitor.c | 4 ++--
> 2 files changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Andreas Färber <address@hidden>
Thanks,
Andreas
Re: [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259, Andreas Färber, 2015/03/30
Re: [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259, Peter Maydell, 2015/03/31
[Qemu-devel] [PATCH 1/6] Split serial-isa into its own config option, David Gibson, 2015/03/05