[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cp

From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model
Date: Tue, 31 Mar 2015 15:35:26 -0300
User-agent: Mutt/1.5.23 (2014-03-12)

On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote:
> This patch implements a new QMP request named 'query-cpu-model'.
> It returns the cpu model of cpu 0 and its backing accelerator.
> request:
>   {"execute" : "query-cpu-model" }
> answer:
>   {"return" : {"name": "2827-ga2", "accel": "kvm" }}
> Alias names are resolved to their respective machine type and GA names
> already during cpu instantiation. Thus, also a cpu model like 'host'
> which is implemented as alias will return its normalized cpu model name.
> Furthermore the patch implements the following function:
> - s390_cpu_models_used(), returns true if S390 cpu models are in use
> Signed-off-by: Michael Mueller <address@hidden>
> ---
> +static inline char *strdup_s390_cpu_name(S390CPUClass *cc)
> +{
> +    return g_strdup_printf("%04x-ga%u", cc->proc.type, cc->mach.ga);
> +}

How exactly is this information going to be used by clients? If getting
the correct type and ga values is important for them, maybe you could
add them as integer fields, instead of requiring clients to parse the
CPU model name?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]