[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in sc
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in schema json |
Date: |
Wed, 1 Apr 2015 10:31:50 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 31.03.2015 um 22:09 hat Markus Armbruster geschrieben:
> Kevin Wolf <address@hidden> writes:
>
> > Am 24.03.2015 um 21:03 hat Eric Blake geschrieben:
> >> From: Fam Zheng <address@hidden>
> >>
> >> In the near term, we will use it for a sensible-looking
> >> 'gen':false inside command declarations, instead of the
> >> current ugly 'gen':'no'.
> >>
> >> In the long term, it will allow conversion from shorthand
> >> with defaults mentioned only in side-band documentation:
> >> 'data':{'*flag':'bool', '*string':'str'}
> >> into an explicit default value documentation, as in:
> >> 'data':{'flag':{'type':'bool', 'optional':true, 'default':true},
> >> 'string':{'type':'str', 'optional':true, 'default':null}}
> >
> > FWIW, I don't think that's a very friendly syntax for humans, it's a bit
> > verbose. But that's no reason not to allow true/false/null, of course.
>
> Here's my current thinking.
>
> Longhand:
>
> # mandatory
> 'name': { 'type': 'str' }
> # optional, with a default
> 'flag': { 'type': 'bool', 'default': true }
> # optional, no default
> 'string': { 'type': 'str', 'default': null }
>
> Presence of 'default' implies optional.
>
> Equivalent shorthand, if any:
>
> 'name': 'str'
> '*string': 'str'
A nice shorthand for defaults would be:
'*name': 'str' = 'default'
Though that would be neither valid JSON nor Python any more. Do we
actually rely on this property anywhere or is it only parsed by the QAPI
generator anyway and we can extend the language in such ways?
Kevin