qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.3] hw/arm/vexpress: Don't double-free flas


From: Gonglei
Subject: Re: [Qemu-devel] [PATCH for-2.3] hw/arm/vexpress: Don't double-free flash filename
Date: Thu, 2 Apr 2015 19:14:23 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 2015/4/2 17:52, Peter Maydell wrote:
> Commits 6e05a12f8f7f and db25a1581 both attempt to fix the
> same "failed to free memory containing flash filename" bug,
> with the effect that when they were both applied we ended
> up freeing the memory twice. Delete the spurious extra free.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> Shannon's patch fixes the virt.c board; I checked the other
> boards touched by 6e05a12f8f7f and they don't have the problem
> (either due to no conflicting patch or because the g_free()
> calls were in the same place and the merge combined them.)
> 
>  hw/arm/vexpress.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c
> index dd04527..54dd967 100644
> --- a/hw/arm/vexpress.c
> +++ b/hw/arm/vexpress.c
> @@ -583,7 +583,6 @@ static void vexpress_common_init(MachineState *machine)
>              error_report("Could not load ROM image '%s'", bios_name);
>              exit(1);
>          }
> -        g_free(fn);
>      }
>  
>      /* Motherboard peripherals: the wiring is the same but the
> 

Reviewed-by: Gonglei <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]