qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 3/5] target-tricore: Fix check which was always false


From: Michael Tokarev
Subject: [Qemu-devel] [PULL 3/5] target-tricore: Fix check which was always false
Date: Sat, 4 Apr 2015 10:10:24 +0300

From: Stefan Weil <address@hidden>

With a mask value of 0x00400000, the result will never be 1.
This fixes a Coverity warning.

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
 target-tricore/op_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target-tricore/op_helper.c b/target-tricore/op_helper.c
index 220ec4a..9907e07 100644
--- a/target-tricore/op_helper.c
+++ b/target-tricore/op_helper.c
@@ -2573,7 +2573,7 @@ void helper_rslcx(CPUTriCoreState *env)
         /* CSU trap */
     }
     /* if (PCXI.UL == 1) then trap(CTYP); */
-    if ((env->PCXI & MASK_PCXI_UL) == 1) {
+    if ((env->PCXI & MASK_PCXI_UL) != 0) {
         /* CTYP trap */
     }
     /* EA = {PCXI.PCXS, 6'b0, PCXI.PCXO, 6'b0}; */
-- 
2.1.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]