[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 00/20] Generate ACPI v5.1 tables and expose i
From: |
Shannon Zhao |
Subject: |
Re: [Qemu-devel] [PATCH v4 00/20] Generate ACPI v5.1 tables and expose it to guest over fw_cfg on ARM |
Date: |
Tue, 7 Apr 2015 20:18:18 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 2015/4/7 20:07, Peter Maydell wrote:
> On 7 April 2015 at 03:43, Shannon Zhao <address@hidden> wrote:
>> The ACPI table entry:
>> Method (_CBA, 0, NotSerialized) // _CBA: Configuration Base
>> Address
>> {
>> Return (0x3F000000)
>> }
>> Method (_CRS, 0, NotSerialized) // _CRS: Current Resource
>> Settings
>> {
>> Name (RBUF, ResourceTemplate ()
>> {
>> WordBusNumber (ResourceProducer, MinFixed, MaxFixed,
>> PosDecode,
>> 0x0000, // Granularity
>> 0x0000, // Range Minimum
>> 0x000F, // Range Maximum
>> 0x0000, // Translation Offset
>> 0x0010, // Length
>> ,, )
>> DWordMemory (ResourceProducer, PosDecode, MinFixed,
>> MaxFixed, Cacheable, ReadWrite,
>> 0x00000000, // Granularity
>> 0x10000000, // Range Minimum
>> 0x3EFF0000, // Range Maximum
>> 0x00000000, // Translation Offset
>> 0x2EFF0000, // Length
>
> In all the other sections, the Length entry is (rangemax - rangemin) + 1,
> but in this one it is not, which suggests an error. Probably your
> rangemax here is wrong, since 0x3eff0000 is actually the first address
> in the IO window.
>
So sorry that the ACPI table entry I pasted is the old version while the code
is update.
+ aml_append(rbuf,
+ aml_dword_memory(aml_pos_decode, aml_min_fixed, aml_max_fixed,
+ aml_cacheable, aml_ReadWrite,
+ 0x0000, info->pcie_mmio_base,
+ info->pcie_mmio_base + info->pcie_mmio_size - 1,
+ 0x0000, info->pcie_mmio_size));
> (If ACPI is effectively describing the length of the range in
> two separate places, it's a shame it doesn't sanity check that
> they both agree...)
>
- Re: [Qemu-devel] [PATCH v4 08/20] hw/arm/virt-acpi-build: Generate MADT table, (continued)
- [Qemu-devel] [PATCH v4 17/20] hw/acpi/aml-build: Add aml_create_dword_field() term, Shannon Zhao, 2015/04/03
- Re: [Qemu-devel] [PATCH v4 00/20] Generate ACPI v5.1 tables and expose it to guest over fw_cfg on ARM, Mark Salter, 2015/04/06
- Re: [Qemu-devel] [PATCH v4 00/20] Generate ACPI v5.1 tables and expose it to guest over fw_cfg on ARM, Peter Maydell, 2015/04/07
- Re: [Qemu-devel] [PATCH v4 00/20] Generate ACPI v5.1 tables and expose it to guest over fw_cfg on ARM,
Shannon Zhao <=
- Re: [Qemu-devel] [PATCH v4 00/20] Generate ACPI v5.1 tables and expose it to guest over fw_cfg on ARM, Igor Mammedov, 2015/04/07
- Re: [Qemu-devel] [PATCH v4 00/20] Generate ACPI v5.1 tables and expose it to guest over fw_cfg on ARM, Michael S. Tsirkin, 2015/04/08
Re: [Qemu-devel] [PATCH v4 00/20] Generate ACPI v5.1 tables and expose it to guest over fw_cfg on ARM, Michael S. Tsirkin, 2015/04/15