[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qapi: Accept 'null' in QMP
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] qapi: Accept 'null' in QMP |
|
Date: |
Tue, 07 Apr 2015 09:11:53 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/07/2015 06:46 AM, Alberto Garcia wrote:
> On Thu, Apr 02, 2015 at 01:31:46PM -0600, Eric Blake wrote:
>
>> So instead, this patch creates a new QObject subtype: QNull.
>
> The code looks good, but Markus's approach of using a single instance
> seems probably a bit better for this case.
It's what we get for both independently tackling the same problem. I
still plan to review Markus' series, and might post an updated version
that takes the best of our two approaches.
>
>> --- /dev/null
>> +++ b/include/qapi/qmp/qnull.h
>> @@ -0,0 +1,23 @@
>> +/*
>> + * QBool Module
>
> You probably meant QNull here.
My blatant use of copy-and-paste shines through :) I'll certainly fix
that, if my approach is still worth using.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature