qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/14] memory: Add MemTxAttrs, MemTxResult to io


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 02/14] memory: Add MemTxAttrs, MemTxResult to io_mem_read and io_mem_write
Date: Wed, 8 Apr 2015 11:59:50 +0100

On 8 April 2015 at 11:51, Paolo Bonzini <address@hidden> wrote:
> This could be the occasion to drop io_mem_read/io_mem_write and use
> memory_region_dispatch_read/memory_region_dispatch_write altogether.  As
> you prefer.

Makes sense, I guess; memory_region_* are better named for
what they do, so promoting those to non-static and dropping
the wrappers seems a good move.

Incidentally in the course of this patch I noticed that we have
exactly two places outside the memory system that use these
functions: hw/s390x/s390-pci-inst.c and hw/vfio/pci.c. Is
this a reasonable thing, or should they in an ideal world
have created an AddressSpace to access things through?
(I have no opinion except that functions used in only one
or two places always look a little suspicious to me :-))

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]