[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode() |
Date: |
Wed, 8 Apr 2015 21:02:49 +0100 |
The second argument of g_base64_decode() is a 'gsize *', not a
'size_t *'. Some compilation environments (like building 32-bit PPC
binaries on a PPC64 system) will complain about the mismatch:
CC qga/commands-posix.o
qga/commands-posix.c: In function 'qmp_guest_set_user_password':
qga/commands-posix.c:1908:5: error: passing argument 2 of 'g_base64_decode'
from incompatible pointer type [-Werror]
In file included from /usr/include/glib-2.0/glib.h:37:0,
from qga/commands-posix.c:14:
/usr/include/glib-2.0/glib/gbase64.h:49:9: note: expected ‘gsize *’ but
argument is of type ‘size_t *’
(We previously fixed errors of this type in commit 3d1bba20.)
Signed-off-by: Peter Maydell <address@hidden>
---
qga/commands-posix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index ba8de62..9fde348 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -1901,7 +1901,7 @@ void qmp_guest_set_user_password(const char *username,
int status;
int datafd[2] = { -1, -1 };
char *rawpasswddata = NULL;
- size_t rawpasswdlen;
+ gsize rawpasswdlen;
char *chpasswddata = NULL;
size_t chpasswdlen;
--
1.9.1
- [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode(),
Peter Maydell <=